Branches and pull requests are for outside contributors; the maintainer's own work, and work done with the maintainer, goes straight onto main, one topic per commit.
3.2 KiB
Fastpotify agent guide
Follow CONTRIBUTING.md; it is the canonical product and contribution policy.
These instructions add implementation constraints for coding agents.
Product boundaries
- Keep Fastpotify a small native Spotify client. Do not add a browser engine, telemetry, a hosted backend, or alternate sources for Spotify audio.
- Playback capabilities come from librespot. Do not advertise or implement a capability merely because its name appears in a protobuf or enum. In particular, do not pursue Spotify Lossless or DRM circumvention unless lawful support first lands upstream.
- Do not broaden a task into adjacent features or a general refactor. Preserve existing user behaviour unless the task explicitly changes it.
Architecture
src/ui/draws views and emitsActions. Apply actions after drawing insrc/app.rs; do not mutate application state from inside a borrowed view.- Network and playback work belongs on the runtime in
src/backend.rsor in the player engine insrc/player.rs, never as blocking work on the UI thread. - Keep platform integrations behind target-specific modules or
cfgblocks. A fix for one platform must keep the other two targets compiling. - Settings and state files must remain readable, backward compatible, and atomically written. Never log credentials or authorization responses.
- Prefer existing dependencies. Explain any new crate in
Cargo.tomlnext to the dependency when the reason is not obvious.
Read docs/_reference/how-it-connects.md before changing authentication,
Spotify requests, Connect, credential storage, or network behaviour. Read the
nearby module tests before changing a state machine or API fallback.
Branches
Work on main. Commit there directly, one topic per commit, each
compiling and passing the checks on its own. Feature branches and pull
requests are for outside contributors; the maintainer's own work, and
work done with the maintainer, does not go through them.
Definition of done
- Add focused regression tests for changed behaviour. Use the
demofeature for deterministic UI coverage and screenshots. - Update the README and docs when user-visible behaviour, settings, files, or network access changes.
- Run the full checks from
CONTRIBUTING.md. Do not weaken a lint, delete a test, or add anallowmerely to make CI green without explaining why the underlying rule does not apply. - Report platform coverage honestly. Do not claim a platform was tested when it was only compiled or reasoned about.
Releases
A release is not the tag alone. Every one of these moves together:
Cargo.tomlversion (and the lockfile via a build), committed before the tag so the binaries report the right version.- The
v*tag, which triggers the release workflow; replace its generated notes with written ones. docs/_config.ymlfastpotify_version(the download page's links) anddocs/_data/versions.yml(the version dropdown: the new version becomescurrentand points at/download/, the previous one keeps a link to its own GitHub release).- The Homebrew cask in the maintainer's tap and the AUR package, both
from the release's
checksums.txt.
Missing any of these ships a release that lies somewhere; the dropdown was forgotten once already.