fix: keep settings tabs clear of the app version

This commit is contained in:
Felitendo committed 2026-09-17 16:14:11 +02:00
1 parent 70dedfb9ee
commit c1c892ebd9
3 files changed
+30

No files matched your search

+1
View File
@@ -32,6 +32,7 @@ works.
| `0017-Start-on-Wayland-with-an-NVIDIA-GPU` | The app no longer crashes at start under Wayland with the NVIDIA driver. |
| `0018-Update-from-Modrinth-Enhanced-s-...` | Updates come from this project's own signed releases rather than Modrinth's. |
| `0019-Add-accounts-from-other-...` | Sign in to Drasl, Blessing Skin and other account servers, as with Ely.by. |
| `0020-Keep-the-settings-tabs-clear-of-...` | The settings tab list scrolls instead of running over the app version on Linux. |
### Offline accounts
@@ -0,0 +1,27 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Modrinth Enhanced <patches@modrinth-enhanced.invalid>
Date: Thu, 17 Sep 2026 14:23:15 +0200
Subject: [PATCH] Keep the settings tabs clear of the app version
The settings tab list is sized to its column with a percentage height,
which WebKitGTK leaves unresolved inside a flex item without a set
height. The list then ran on over the app version at the bottom of the
column instead of scrolling. It fills its column absolutely now, the way
the content beside it already does.
---
packages/ui/src/components/modal/TabbedModal.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packages/ui/src/components/modal/TabbedModal.vue b/packages/ui/src/components/modal/TabbedModal.vue
index 4715916..1b1d69a 100644
--- a/packages/ui/src/components/modal/TabbedModal.vue
+++ b/packages/ui/src/components/modal/TabbedModal.vue
@@ -158,7 +158,7 @@ defineExpose({ show, hide, selectedTab, setTab })
<div
ref="sidebarScrollContainer"
- class="flex h-full flex-col gap-1 overflow-y-auto"
+ class="absolute inset-0 flex flex-col gap-1 overflow-y-auto"
@scroll="checkSidebarScrollState"
>
<template v-for="(tab, index) in visibleTabs" :key="index">
+2
View File
@@ -189,6 +189,8 @@ check "the middle button autoscrolls" \
contains "$WORKTREE/apps/app-frontend/src/App.vue" 'installAutoscroll()'
check "file pickers use the desktop portal on Linux" \
contains "$WORKTREE/apps/app/src/main.rs" 'set_var("GTK_USE_PORTAL", "1")'
check "the settings tabs scroll instead of covering the version" \
contains "$WORKTREE/packages/ui/src/components/modal/TabbedModal.vue" 'class="absolute inset-0 flex flex-col gap-1 overflow-y-auto"'
check "NVIDIA under Wayland does not crash the webview" \
contains "$WORKTREE/apps/app/src/main.rs" 'set_var("WEBKIT_DMABUF_RENDERER_FORCE_SHM", "1")'